Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Feat: add unit tests and specific version checks on alpine as base_image #52

Closed
FaGru3n opened this issue Oct 10, 2023 · 0 comments · Fixed by eclipse-tractusx/sig-release#514
Assignees
Labels
enhancement New feature or request

Comments

@FaGru3n
Copy link
Contributor

FaGru3n commented Oct 10, 2023

Just generated the issue to document an idea from @SebastianBezold

I think it is ok to merge it, but I'm missing some examples in our unit-tests. The check is currently just doing a lazy contains. This would allow too many images in my opinion. So what do we want to allow as base image here? is it plain alpine, or is it every image, that is based on alpine like a postgres alpine image for example?

We should add proper unit-tests with allowed and unallowed examples and enhance the isAllowedBaseImage function

see #51 (comment))

related to this go check file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants