From 45dd65a58e38cfe64cf392ef523afdab6dd04fe5 Mon Sep 17 00:00:00 2001
From: Dennis Hendriks <dh_tue@hotmail.com>
Date: Sun, 13 Aug 2023 17:02:18 +0200
Subject: [PATCH] tycho-its reproducer p2Repository.downloadVerifyNoDigestAlgo
 (#2710)

---
 .../pom.xml                                   | 82 +++++++++++++++++++
 .../test.feature/build.properties             |  2 +
 .../test.feature/extra.txt                    |  1 +
 .../test.feature/feature.xml                  | 16 ++++
 .../test.feature/pom.xml                      | 16 ++++
 .../test.product/category.xml                 |  2 +
 .../test.product/pom.xml                      | 31 +++++++
 .../test.product/test.product                 | 17 ++++
 .../test.target/pom.xml                       | 15 ++++
 .../test.target/test.target                   | 37 +++++++++
 .../DownloadVerifyNoDigestAlgoTest.java       | 25 ++++++
 11 files changed, 244 insertions(+)
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/pom.xml
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/build.properties
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/extra.txt
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/feature.xml
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/pom.xml
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/category.xml
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/pom.xml
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/test.product
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.target/pom.xml
 create mode 100644 tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.target/test.target
 create mode 100644 tycho-its/src/test/java/org/eclipse/tycho/test/p2Repository/DownloadVerifyNoDigestAlgoTest.java

diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/pom.xml b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/pom.xml
new file mode 100644
index 0000000000..46278f2207
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/pom.xml
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <groupId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo</groupId>
+    <artifactId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.root</artifactId>
+    <version>1.0.0-SNAPSHOT</version>
+
+    <packaging>pom</packaging>
+
+    <modules>
+        <module>test.feature</module>
+        <module>test.product</module>
+        <module>test.target</module>
+    </modules>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.eclipse.tycho</groupId>
+                <artifactId>tycho-maven-plugin</artifactId>
+                <version>${tycho-version}</version>
+                <extensions>true</extensions>
+            </plugin>
+            <plugin>
+                <groupId>org.eclipse.tycho</groupId>
+                <artifactId>tycho-compiler-plugin</artifactId>
+                <version>${tycho-version}</version>
+            </plugin>
+            <plugin>
+                <groupId>org.eclipse.tycho</groupId>
+                <artifactId>tycho-packaging-plugin</artifactId>
+                <version>${tycho-version}</version>
+            </plugin>
+            <plugin>
+                <groupId>org.eclipse.tycho</groupId>
+                <artifactId>target-platform-configuration</artifactId>
+                <version>${tycho-version}</version>
+                <configuration>
+                    <target>
+                        <artifact>
+                            <groupId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo</groupId>
+                            <artifactId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.target</artifactId>
+                            <version>1.0.0-SNAPSHOT</version>
+                        </artifact>
+                    </target>
+                    <executionEnvironment>org.eclipse.justj.openjdk.hotspot.jre.full-17</executionEnvironment>
+                    <environments>
+                        <environment>
+                            <os>linux</os>
+                            <ws>gtk</ws>
+                            <arch>x86_64</arch>
+                        </environment>
+                    </environments>
+                    <pomDependencies>consider</pomDependencies>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.eclipse.tycho</groupId>
+                <artifactId>tycho-p2-plugin</artifactId>
+                <version>${tycho-version}</version>
+                <executions>
+                    <execution>
+                        <id>default-p2-metadata-default</id>
+                        <configuration>
+                            <attachP2Metadata>false</attachP2Metadata>
+                        </configuration>
+                    </execution>
+                    <execution>
+                        <id>attach-p2-metadata</id>
+                        <phase>package</phase>
+                        <goals>
+                            <goal>p2-metadata</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
+
+</project>
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/build.properties b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/build.properties
new file mode 100644
index 0000000000..28874d8ee4
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/build.properties
@@ -0,0 +1,2 @@
+bin.includes=feature.xml
+root=file:extra.txt
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/extra.txt b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/extra.txt
new file mode 100644
index 0000000000..747e5336cf
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/extra.txt
@@ -0,0 +1 @@
+Intentionally empty file.
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/feature.xml b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/feature.xml
new file mode 100644
index 0000000000..cb22aa4dc7
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/feature.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<feature
+      id="tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.feature"
+      label="Test Feature"
+      version="1.0.0.qualifier">
+
+   <requires>
+      <import feature="org.eclipse.platform" version="4.27.0" match="compatible"/>
+      <import feature="org.eclipse.justj.openjdk.hotspot.jre.full" version="17.0.5" match="compatible"/>
+      <import plugin="org.eclipse.pde.runtime"/>
+   </requires>
+
+   <plugin id="com.github.com-github-javabdd.com.github.javabdd" version="6.0.0" match="compatible"/>
+   <plugin id="org.apache.commons.commons-text" version="1.10.0" match="compatible"/>
+
+</feature>
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/pom.xml b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/pom.xml
new file mode 100644
index 0000000000..58ec730e97
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.feature/pom.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo</groupId>
+        <artifactId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.root</artifactId>
+        <version>1.0.0-SNAPSHOT</version>
+        <relativePath>..</relativePath>
+    </parent>
+
+    <artifactId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.feature</artifactId>
+    <packaging>eclipse-feature</packaging>
+
+</project>
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/category.xml b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/category.xml
new file mode 100644
index 0000000000..8cfa259357
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/category.xml
@@ -0,0 +1,2 @@
+<site>
+</site>
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/pom.xml b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/pom.xml
new file mode 100644
index 0000000000..f9d929894c
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/pom.xml
@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo</groupId>
+        <artifactId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.root</artifactId>
+        <version>1.0.0-SNAPSHOT</version>
+        <relativePath>..</relativePath>
+    </parent>
+
+    <artifactId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.product</artifactId>
+    <packaging>eclipse-repository</packaging>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.eclipse.tycho</groupId>
+                <artifactId>tycho-p2-repository-plugin</artifactId>
+                <version>${tycho-version}</version>
+            </plugin>
+            <plugin>
+                <groupId>org.eclipse.tycho</groupId>
+                <artifactId>tycho-p2-director-plugin</artifactId>
+                <version>${tycho-version}</version>
+            </plugin>
+        </plugins>
+    </build>
+
+</project>
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/test.product b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/test.product
new file mode 100644
index 0000000000..9410cb6ebf
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.product/test.product
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<?pde version="3.5"?>
+<product name="Test product" uid="tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.product" id="tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.product" application="org.eclipse.ui.ide.workbench" version="1.0.0.qualifier" useFeatures="true" includeLaunchers="true" autoIncludeRequirements="true">
+
+   <features>
+      <feature id="tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.feature" version="1.0.0.qualifier"/>
+   </features>
+
+   <configurations>
+      <plugin id="org.apache.felix.scr" autoStart="true" startLevel="2" />
+      <plugin id="org.eclipse.core.runtime" autoStart="true" startLevel="0" />
+      <plugin id="org.eclipse.equinox.common" autoStart="true" startLevel="2" />
+      <plugin id="org.eclipse.equinox.event" autoStart="true" startLevel="2" />
+      <plugin id="org.eclipse.equinox.simpleconfigurator" autoStart="true" startLevel="1" />
+   </configurations>
+
+</product>
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.target/pom.xml b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.target/pom.xml
new file mode 100644
index 0000000000..80e90d4214
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.target/pom.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+
+    <parent>
+        <groupId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo</groupId>
+        <artifactId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.root</artifactId>
+        <version>1.0.0-SNAPSHOT</version>
+        <relativePath>..</relativePath>
+    </parent>
+
+    <artifactId>tycho-its-project.p2Repository.downloadVerifyNoDigestAlgo.target</artifactId>
+    <packaging>eclipse-target-definition</packaging>
+</project>
diff --git a/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.target/test.target b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.target/test.target
new file mode 100644
index 0000000000..a2cdca14cd
--- /dev/null
+++ b/tycho-its/projects/p2Repository.downloadVerifyNoDigestAlgo/test.target/test.target
@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<?pde version="3.8"?>
+<target name="Test Target Platform">
+    <locations>
+        <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
+            <unit id="org.eclipse.equinox.executable.feature.group" version="0.0.0"/>
+            <unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
+            <repository location="https://download.eclipse.org/releases/2023-03"/>
+        </location>
+        <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
+            <unit id="org.eclipse.justj.openjdk.hotspot.jre.full.feature.group" version="0.0.0"/>
+            <repository location="https://download.eclipse.org/justj/jres/17/updates/release/17.0.5"/>
+        </location>
+        <location includeDependencyDepth="none" includeDependencyScopes="compile" includeSource="true" missingManifest="error" type="Maven">
+            <dependencies>
+                <dependency>
+                    <groupId>com.github.com-github-javabdd</groupId>
+                    <artifactId>com.github.javabdd</artifactId>
+                    <version>6.0.0</version>
+                    <type>jar</type>
+                </dependency>
+                <dependency>
+                    <groupId>org.apache.commons</groupId>
+                    <artifactId>commons-lang3</artifactId>
+                    <version>3.1</version>
+                    <type>jar</type>
+                </dependency>
+                <dependency>
+                    <groupId>org.apache.commons</groupId>
+                    <artifactId>commons-text</artifactId>
+                    <version>1.10.0</version>
+                    <type>jar</type>
+                </dependency>
+            </dependencies>
+        </location>
+    </locations>
+</target>
\ No newline at end of file
diff --git a/tycho-its/src/test/java/org/eclipse/tycho/test/p2Repository/DownloadVerifyNoDigestAlgoTest.java b/tycho-its/src/test/java/org/eclipse/tycho/test/p2Repository/DownloadVerifyNoDigestAlgoTest.java
new file mode 100644
index 0000000000..db6cd4a84a
--- /dev/null
+++ b/tycho-its/src/test/java/org/eclipse/tycho/test/p2Repository/DownloadVerifyNoDigestAlgoTest.java
@@ -0,0 +1,25 @@
+/*******************************************************************************
+ * Copyright (c) 2023 Contributors to the Eclipse Foundation
+ * This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License 2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *******************************************************************************/
+
+package org.eclipse.tycho.test.p2Repository;
+
+import org.apache.maven.it.Verifier;
+import org.eclipse.tycho.test.AbstractTychoIntegrationTest;
+import org.junit.Test;
+
+public class DownloadVerifyNoDigestAlgoTest extends AbstractTychoIntegrationTest {
+    @Test
+    public void test() throws Exception {
+        Verifier verifier = getVerifier("p2Repository.downloadVerifyNoDigestAlgo", false);
+        verifier.executeGoal("verify");
+        verifier.verifyErrorFreeLog();
+        verifyTextNotInLog(verifier, "No digest algorithm is available to verify download");
+    }
+}