From ca5b976795b5eefe9f7073bfa1d1a32e5183d9a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20L=C3=A4ubrich?= <laeubi@laeubi-soft.de>
Date: Sun, 3 Dec 2023 06:52:59 +0100
Subject: [PATCH] Remove readonly from parameter to prevent maven warning

Fix https://github.com/eclipse-tycho/tycho/issues/2644
---
 .../main/java/org/eclipse/tycho/core/maven/AbstractP2Mojo.java  | 2 +-
 .../tycho/plugins/p2/extras/CompareWithBaselineMojo.java        | 2 +-
 .../java/org/eclipse/tycho/source/AbstractSourceJarMojo.java    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tycho-core/src/main/java/org/eclipse/tycho/core/maven/AbstractP2Mojo.java b/tycho-core/src/main/java/org/eclipse/tycho/core/maven/AbstractP2Mojo.java
index 01c103d55a..e7ff710d06 100644
--- a/tycho-core/src/main/java/org/eclipse/tycho/core/maven/AbstractP2Mojo.java
+++ b/tycho-core/src/main/java/org/eclipse/tycho/core/maven/AbstractP2Mojo.java
@@ -36,7 +36,7 @@ public abstract class AbstractP2Mojo extends AbstractMojo {
     @Parameter(property = "project", readonly = true)
     private MavenProject project;
 
-    @Parameter(property = "buildQualifier", readonly = true)
+    @Parameter(property = "buildQualifier")
     private String qualifier;
 
     @Component
diff --git a/tycho-extras/tycho-p2-extras-plugin/src/main/java/org/eclipse/tycho/plugins/p2/extras/CompareWithBaselineMojo.java b/tycho-extras/tycho-p2-extras-plugin/src/main/java/org/eclipse/tycho/plugins/p2/extras/CompareWithBaselineMojo.java
index 057f4ab294..45682644c2 100644
--- a/tycho-extras/tycho-p2-extras-plugin/src/main/java/org/eclipse/tycho/plugins/p2/extras/CompareWithBaselineMojo.java
+++ b/tycho-extras/tycho-p2-extras-plugin/src/main/java/org/eclipse/tycho/plugins/p2/extras/CompareWithBaselineMojo.java
@@ -118,7 +118,7 @@ public static enum ReportBehavior {
      * The hint of an available {@link ArtifactComparator} component to use for comparison of
      * artifacts with same version.
      */
-    @Parameter(defaultValue = BytesArtifactComparator.HINT, readonly = true)
+    @Parameter(defaultValue = BytesArtifactComparator.HINT)
     private String comparator;
     @Component(role = ArtifactComparator.class)
     protected Map<String, ArtifactComparator> artifactComparators;
diff --git a/tycho-source-plugin/src/main/java/org/eclipse/tycho/source/AbstractSourceJarMojo.java b/tycho-source-plugin/src/main/java/org/eclipse/tycho/source/AbstractSourceJarMojo.java
index 1f8ceb93a4..9e411efb15 100644
--- a/tycho-source-plugin/src/main/java/org/eclipse/tycho/source/AbstractSourceJarMojo.java
+++ b/tycho-source-plugin/src/main/java/org/eclipse/tycho/source/AbstractSourceJarMojo.java
@@ -122,7 +122,7 @@ public abstract class AbstractSourceJarMojo extends AbstractMojo {
      *
      * @since 2.1
      */
-    @Parameter(defaultValue = "${project.build.outputDirectory}/META-INF/MANIFEST.MF", required = true, readonly = true)
+    @Parameter(defaultValue = "${project.build.outputDirectory}/META-INF/MANIFEST.MF", required = true)
     private File defaultManifestFile;
 
     /**