Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken JDT null-analysis in tycho 3.x #2441

Closed
cdietrich opened this issue May 26, 2023 · 3 comments
Closed

Fix for broken JDT null-analysis in tycho 3.x #2441

cdietrich opened this issue May 26, 2023 · 3 comments

Comments

@cdietrich
Copy link
Contributor

Hi,

it would be nice to have a Tycho 3.x version with the final JDT 2023-06 artifacts with the fix for eclipse-jdt/eclipse.jdt.core#1007 as the problem is also visible in tycho as eclipse-jdt/eclipse.jdt.core#1093 demonstrates.

If a new 3.x version is not possible: is it possible to overide the jdt/ecj version the tycho compiler plugin uses?

@laeubi
Copy link
Member

laeubi commented May 26, 2023

As soon as it is promoted to Maven Central (!) both is possible.

Custom compiler configuration:

<plugin>
  <groupId>org.eclipse.tycho</groupId>
  <artifactId>tycho-compiler-plugin</artifactId>
  <version>${tycho-version}</version>
  <dependencies>
    <dependency>
      <groupId>org.eclipse.jdt</groupId>
      <artifactId>ecj</artifactId>
      <version><yournewversion></version>
    </dependency>
  </dependencies>
</plugin>

cdietrich added a commit to cdietrich/tycho that referenced this issue May 26, 2023
Fixes eclipse-tycho#2441

Signed-off-by: Christian Dietrich <[email protected]>
@cdietrich
Copy link
Contributor Author

nice.

i tested with

				<dependencies>
					<dependency>
						<groupId>org.eclipse.jdt</groupId>
						<artifactId>ecj</artifactId>
						<version>3.34.0-SNAPSHOT</version>
					</dependency>
				</dependencies>
	<pluginRepositories>
		<pluginRepository>
			<id>eclipse-snapshots</id>
			<url>https://repo.eclipse.org/content/groups/eclipse/</url>
			<releases>
				<enabled>false</enabled>
			</releases>
			<snapshots>
				<enabled>true</enabled>
			</snapshots>
		</pluginRepository>
	</pluginRepositories>

and the problem seems to be gone. thx

laeubi pushed a commit to cdietrich/tycho that referenced this issue Jun 13, 2023
Fixes eclipse-tycho#2441

Signed-off-by: Christian Dietrich <[email protected]>
laeubi pushed a commit that referenced this issue Jun 13, 2023
Fixes #2441

Signed-off-by: Christian Dietrich <[email protected]>
@laeubi
Copy link
Member

laeubi commented Nov 28, 2023

@cdietrich I'll close this for now as release is on central and it seems you got a solution.

@laeubi laeubi closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants