Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds repository creation to its example using Eclipse features in target platform #2890

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Oct 6, 2023

Demonstrates that an Eclipse feature and its dependencies from the target platform can also be used to create the content of an update site.

@laeubi
Copy link
Member

laeubi commented Oct 6, 2023

@vogella can you add to the corresponding testcase some asserts that check for the new expected items?

@@ -0,0 +1,28 @@
<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project files are usually not required to be included in integration tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project files are usually not required to be included in integration tests.

Thanks. Removed

@vogella vogella force-pushed the using-eclipse-features-in-updatesites branch from 814a404 to 03513e7 Compare October 6, 2023 08:09
@vogella
Copy link
Contributor Author

vogella commented Oct 6, 2023

testcase

Will do, thanks for the suggestion.

example

Demonstrates that an Eclipse feature and its dependencies from the
target platform can also be used to create the content of an update
site.
@vogella vogella force-pushed the using-eclipse-features-in-updatesites branch from 03513e7 to 197cfd1 Compare October 6, 2023 10:11
@vogella
Copy link
Contributor Author

vogella commented Oct 6, 2023

I added a check to the test for the expected feature.jar in the generate update site. My local build for Tycho is still running to validate this.

@laeubi
Copy link
Member

laeubi commented Oct 6, 2023

You can do

mvn clean install -DskipTests -T1C

then go into the tycho-its folder and execute

mvn clean install -Pits -Dtycho.mvnDebug=8000 -Dtest=org.eclipse.tycho.test.target.TargetPlatformLocationsTest

that should speedup development/verification of your changes.

@vogella
Copy link
Contributor Author

vogella commented Oct 6, 2023

mvn clean install -Pits -Dtycho.mvnDebug=8000 -Dtest=org.eclipse.tycho.test.target.TargetPlatformLocationsTest works fine locally (and is fast). Thanks @laeubi

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Test Results

   561 files  ±0     561 suites  ±0   4h 46m 9s ⏱️ + 12m 3s
   364 tests ±0     358 ✔️ ±0    6 💤 ±0  0 ±0 
1 092 runs  ±0  1 073 ✔️ ±0  19 💤 ±0  0 ±0 

Results for commit 197cfd1. ± Comparison against base commit cbc0f06.

@laeubi laeubi merged commit e154832 into eclipse-tycho:master Oct 6, 2023
8 checks passed
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants