Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated ProductFile2 #2927

Merged

Conversation

HannesWell
Copy link
Member

@laeubi is there a reason to keep ProductFile2 duplicated or is this unintended?

@HannesWell HannesWell added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Oct 15, 2023
@laeubi
Copy link
Member

laeubi commented Oct 15, 2023

It could be that previously where we have some bundle world and some maven world it was easier to copy than share this. If its really a duplicate it should be possible to only use one variant now.

@HannesWell
Copy link
Member Author

Understand.
Then lets see what the build says and if it suceeds I assume it is safe to submit it.

@github-actions
Copy link

Test Results

   561 files  ±0     561 suites  ±0   4h 30m 33s ⏱️ - 12m 57s
   364 tests ±0     358 ✔️ ±0    6 💤 ±0  0 ±0 
1 092 runs  ±0  1 073 ✔️ ±0  19 💤 ±0  0 ±0 

Results for commit 64ec137. ± Comparison against base commit 157c7a2.

@HannesWell
Copy link
Member Author

All builds are green.
Then lets go with this one.

@HannesWell HannesWell merged commit 1a82572 into eclipse-tycho:master Oct 15, 2023
9 checks passed
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@HannesWell HannesWell deleted the remove-duplicated-ProductFile2 branch October 15, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants