Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a requirement's filter and max when computing dependencies #3198

Closed
wants to merge 1 commit into from

Conversation

merks
Copy link
Contributor

@merks merks commented Dec 9, 2023

@laeubi
Copy link
Member

laeubi commented Dec 9, 2023

@merks thanks for looking into this, sadly this now fails to discover dependencies from SWT>Fragement (at least I suspect that's what the error in "Individual Bundles Build" seem to cause). so I think one can not completely ignore any requirement that has a filter.

Copy link

github-actions bot commented Dec 9, 2023

Test Results

384 files  +2  384 suites  +2   2h 17m 37s ⏱️ - 32m 34s
377 tests +1  365 ✔️  - 5    6 💤 ±0  1 +1  5 🔥 +5 
754 runs  +2  731 ✔️  - 8  13 💤 ±0  1 +1  9 🔥 +9 

For more details on these failures and errors, see this check.

Results for commit 208b1c6. ± Comparison against base commit b193066.

@laeubi
Copy link
Member

laeubi commented Dec 10, 2023

@merks thanks for the testcase this was included here:

and should support full profile properties filtering.

@merks
Copy link
Contributor Author

merks commented Dec 11, 2023

Changes this this have superseded this attempt, and the following test case is much simpler:

#3227

@merks merks closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants