Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the profile properties so they can be considered in the resolve #3204

Closed
wants to merge 3 commits into from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 10, 2023

This includes the testcase and preliminary work from

@laeubi
Copy link
Member Author

laeubi commented Dec 10, 2023

No the individual bundles build fails :-
Lets see if the integration test reveal a failure to give some more indication what could be the cause...

@laeubi
Copy link
Member Author

laeubi commented Dec 10, 2023

Thinking more about the failure I think it is caused by the fact that one needs to check if any of the configured target environments can satisfy the filter...

@merks
Copy link
Contributor

merks commented Dec 10, 2023

Yes, if you look at test cases like this one you can see the environments are in the context IU:

image

So probably we should make a context IU for each environment combination specified along with the profile properties:

image

and then check that the filter matches one of such context IUs.

This PR appears to have lost the getMax filtering. It's of course highly relevant to not create a dependency for a negative requirement. The getMax() == 0 requirements could perhaps be filtered out in the first loop where the self requirements are being removed.

Copy link

github-actions bot commented Dec 10, 2023

Test Results

   576 files  +3     576 suites  +3   3h 44m 52s ⏱️ - 8m 18s
   378 tests +1     372 ✔️ +1    6 💤 ±0  0 ±0 
1 134 runs  +3  1 115 ✔️ +3  19 💤 ±0  0 ±0 

Results for commit 7c24bc7. ± Comparison against base commit 2f81c3b.

♻️ This comment has been updated with latest results.

@laeubi laeubi marked this pull request as draft December 10, 2023 16:27
@laeubi
Copy link
Member Author

laeubi commented Dec 13, 2023

@laeubi laeubi closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All statisfied requirements map to dependencies in InstallableUnitSlicer.computeDirectDependencies
2 participants