tycho-versions-plugin: Support ci-friendly versions

[sratz]

In PomFile#getVersion(), resolve properties used in the raw version of the project. This is necessary so that downstream manipulators (MANIFEST.MF, feature.xml, category.xml, ...) can see the actual version and act on it.

Fixes #3744.

[github-actions]

Test Results

  594 files  ±0    594 suites  ±0   3h 56m 55s ⏱️ - 6m 16s
  424 tests +1    417 ✅ +2   7 💤 ±0  0 ❌  - 1 
1 272 runs  +3  1 250 ✅ +4  22 💤 ±0  0 ❌  - 1 

Results for commit 1746be2. ± Comparison against base commit a8592b4.

♻️ This comment has been updated with latest results.

[sratz]

I refactored things a bit more. In fact, the utility is not specific to versions, but just deals with properties in general.

[laeubi]

Looks very good, thank you!

[eclipse-tycho-bot]

💚 All backports created successfully

Status	Branch	Result
✅	tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[HannesWell]

@sratz is it possible that the back-port of this has broken P2's use of version variables/ci-friendly versions?
https://github.com/eclipse-equinox/p2/blob/65348d689980d1e11708f934f1767f056e62907d/pom.xml#L25-L32

Since Tycho 4.0.9 the tycho-versions-plugin:set-parent-version goal cannot set the root version of p2 anymore: <version>${releaseVersion}${qualifier}</version>
See https://github.com/eclipse-equinox/p2/actions/runs/11973081501/job/33420895519

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-versions-plugin:4.0.9:set-parent-version (default-cli) on project rt.equinox.p2: Execution default-cli of goal org.eclipse.tycho:tycho-versions-plugin:4.0.9:set-parent-version failed: No group with name {releaseVersion} -> [Help 1]

I verified it locally that it works with Tycho 4.0.8 and we had corresponding release preparation PRs for p2 in the past.

[HannesWell]

Verified locally that reverting this for tycho 4.0.x makes the p2 case work again:
mvn org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=4.35.0-SNAPSHOT org.eclipse.tycho:tycho-versions-plugin:set-parent-version -DnewParentVersion=4.35.0-SNAPSHOT -Dtycho.version=4.0.11-SNAPSHOT

[sratz]

@sratz is it possible that the back-port of this has broken P2's use of version variables/ci-friendly versions?

I think it brought to light a hidden problem that already existed before:

SetVersionMojo (set-version) is supposed to descend to child modules / projects, while
SetParentVersionMojo (set-parent-version) is not

Is this assumption correct, @laeubi?

SetParentVersionMojo inherits from AbstractChangeMojo and inherits the same descend-logic. This logic, however, always looks at getVersion() of the children.

[laeubi]

@sratz thats was at least the idea of it, but we can of course change things if it performs better.

[sratz]

@laeubi I am trying to understand the original intention of the set-parent-version mojo.

Assuming the following directory structure:

pom.xml
    <version>1.0.0</version>

  child1\pom.xml <-- run org.eclipse.tycho:tycho-versions-plugin:set-parent-version -DnewParentVersion=2.0.0 here
      <parent>
          <version>1.0.0</version>
      </parent>
      <version>1.0.0</version>

    child1\child1a\pom.xml
        <parent>
            <version>1.0.0</version>
        </parent>
        <version>1.0.0</version>

    child1\child1b\pom.xml
        <parent>
            <version>1.0.0</version>
        </parent>
        <version>1.0.0</version>

  child2\pom.xml
      <parent>
          <version>1.0.0</version>
      </parent>
      <version>1.0.0</version>

    child2\child2a\pom.xml
        <parent>
            <version>1.0.0</version>
        </parent>
        <version>1.0.0</version>

    child2\child2b\pom.xml
        <parent>
            <version>1.0.0</version>
        </parent>
        <version>1.0.0</version>

The result is:

pom.xml
    <version>2.0.0</version>

  child1\pom.xml
      <parent>
          <version>2.0.0</version>
      </parent>
      <version>2.0.0</version>

    child1\child1a\pom.xml
        <parent>
            <version>2.0.0</version>
        </parent>
        <version>2.0.0</version>

    child1\child1b\pom.xml
        <parent>
            <version>2.0.0</version>
        </parent>
        <version>2.0.0</version>

  child2\pom.xml
      <parent>
          <version>2.0.0</version>
      </parent>
      <version>2.0.0</version>

    child2\child2a\pom.xml
        <parent>
            <version>2.0.0</version>
        </parent>
        <version>2.0.0</version>

    child2\child2b\pom.xml
        <parent>
            <version>2.0.0</version>
        </parent>
        <version>2.0.0</version>

Versions have essentially changed everywhere, even outside of the current directory.

Is this really the intention of the mojo?

[sratz]

The actual regression and IllegalArgumentException is fixed with #4453. Although I still think the set-parent-version mojo is strange and not really doing what it was intended for :)