Remove no longer valid checksum properties

[laeubi]

Currently Tycho/P2 only adds checksums but as some are now disabled for publish this can lead to the case where an existing checksum is kept as-is.

This now performs and additional check if there are old checksums and remove them when recreate the repository.

This should fix

• fix-artifacts-metadata doesn't fix the md5.checksum #2875

but a testcase is missing.

[github-actions]

Test Results

  597 files    597 suites   4h 23m 11s ⏱️
  425 tests   418 ✅  7 💤 0 ❌
1 275 runs  1 253 ✅ 22 💤 0 ❌

Results for commit ca4c4a8.

♻️ This comment has been updated with latest results.

[mdaloia]

@laeubi Thanks for the fix!

I've made this Integration Test:
laeubi/tycho@fix_2875...mdaloia:tycho:fix_2875-integration-test

Questions:

1. Are you ok with the test name? Open to hear suggestions
2. Is is ok the structure? I went for a simple layout as a multi-module was not required.
3. Is there any guidance about depending on an external Update Site? I saw that some repositories are committed here but I don't know if this is something wanted or not (as even when they are minimal repos they contribute to the total repo weight).
4. Should I do a PR against your cloned Tycho repository or I do a separated PR agains the upstream Tycho repo directly and then you rebase this PR in order to get the test?

Thanks in advance!

[laeubi]

1. File name seems sufficient, in the past I have tried to map plugin-names to test names e.g. https://github.com/eclipse-tycho/tycho/tree/main/tycho-its/projects/tycho-version-plugin and https://github.com/eclipse-tycho/tycho/blob/main/tycho-its/src/test/java/org/eclipse/tycho/test/versionsplugin/TychoVersionsPluginTest.java but it is more something to better find things as a hard rule
2. as simple as possible to demonstrate the issue is fine
3. The general rule is: If we can use the "latest eclipse release" the use that but if not any external site is fine as well as long as it is quite reliable / stable
4. Just open a PR against this repository, then we will see that the test actually shows the problem, I then usually cherry pick the commit to the branch that fixes the problem to prove the fix actually is a fix for the test-case and merge them together.

[mdaloia]

Thanks @laeubi !

I've PR #3921 with the Integration Test.

[mdaloia]

@laeubi As expected, #3921 failed in the new integration test:
https://ci.eclipse.org/tycho/job/tycho-github/job/PR-3921/2/testReport/

Can you review and cherry-pick it into your branch in order to test it pass with your modifications.

Thanks in advance

[laeubi]

@mdaloia testcase should now be part of this PR!

[mdaloia]

@laeubi Well, it seems that it is all green! 👏🏻

[eclipse-tycho-bot]

💚 All backports created successfully

Status	Branch	Result
✅	tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[eclipse-tycho-bot]

💚 All backports created successfully

Status	Branch	Result
✅	tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[tivervac]

I wonder whether this will also fix #4159. I'll confirm when I have the time to test on our side