-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make "include" the default enum value #3246
Conversation
@laeubi on my fork, GitHub Actions shows several IT failures, which I don't understand https://github.com/LorenzoBettini/tycho/actions/runs/7180800199/job/19556904813 The failure seems to be due to
I don't understand where that invalid URI comes from; I guess that with the default use of referenced repositories the problem shows up. |
@LorenzoBettini It's most likely my fault caused by #3224 which #3244 should fix or at least reduce the issue significantly. |
Java enums don't have default values so I'm closing this PR as it is not changing anything. |
@akurtakov isn't the default value for enum 0, which corresponds to the first element of an enum (unless a value is specified, and then automatically incremented)? If there's no default value then why, without my PR, the default is |
It is explicitly set to ignore at tycho/tycho-core/src/main/java/org/eclipse/tycho/core/TargetPlatformConfiguration.java Line 122 in cf8cffa
Enums has ordinal value as you think but the one with ordinal 0 is not the default as there is no way to express that in Java:
|
@akurtakov I had missed that file: I was looking at the target platform configuration mojo where no default was specified and I thought maven would use the first value of the enum. I forgot that mojo is only for documentation purpose.. I'll work on another PR. |
The default for maven is
Yes it is a bit unfortunate at the moment but I haven't found a clean maven solution yet, maybe I can convince the maven devs for Maven4 to offer something better :-)
Thanks, please also include an release note changes in such PR! |
No description provided.