Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build from fork #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erikbosch
Copy link

@erikbosch erikbosch commented Jul 30, 2024

We do not need builds from Pull Requests to be uploaded to ghcr. By removing builds from PRs we solve the problem that PRs originating from a fork cannot upload images to ghcr.

Fixes #70
Replaces #69

Fixes also some CI warnings and improves dash printout

Tested that pusihing to main still creates ghcr image at https://github.com/erikbosch/devcontainer-base-images/pkgs/container/devcontainer-base-images%2Fbase

@erikbosch erikbosch marked this pull request as draft July 30, 2024 11:38
@erikbosch erikbosch marked this pull request as ready for review September 9, 2024 10:25
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if one wants to test a new base image before releasing it on main?

@erikbosch
Copy link
Author

What about if one wants to test a new base image before releasing it on main?

Then there are two ways.

  • You can push to "main" on the "from" repo, that will trigger a build and push. Off course this should not be used if you are a committer and uses the official velocitas repo as "from" repo
  • You can trigger the action manually for your branch on the "from" repo.

I have tested both of these mechanisms, see https://github.com/erikbosch/devcontainer-base-images/pkgs/container/devcontainer-base-images%2Fbase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PRs from fork does not pass CI
2 participants