Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): use tracing and zenoh-util init log #92

Merged
merged 4 commits into from
Apr 16, 2024
Merged

feat(tracing): use tracing and zenoh-util init log #92

merged 4 commits into from
Apr 16, 2024

Conversation

gabrik
Copy link
Contributor

@gabrik gabrik commented Apr 3, 2024

@eclipse-zenoh-bot
Copy link
Contributor

@gabrik If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@gabrik gabrik mentioned this pull request Apr 3, 2024
Merged
@gabrik gabrik marked this pull request as ready for review April 12, 2024 06:15
@gabrik
Copy link
Contributor Author

gabrik commented Apr 12, 2024

@snehilzs can you please have a look?

snehilzs
snehilzs approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@snehilzs snehilzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrik I tested your code. Everything is working properly. LGTM.

@gabrik gabrik merged commit 58c69a3 into main Apr 16, 2024
9 checks passed
@gabrik gabrik deleted the feat/tracing branch April 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snehilzs snehilzs snehilzs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrik @eclipse-zenoh-bot @snehilzs