Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give access to Reply::replier_id #278

Closed
milyin opened this issue Mar 10, 2024 · 2 comments
Closed

give access to Reply::replier_id #278

milyin opened this issue Mar 10, 2024 · 2 comments
Labels
api sync Synchronize API with other bindings

Comments

@milyin
Copy link
Contributor

milyin commented Mar 10, 2024

Describe the release item

zenoh-c doesn't give access to replier_id field of Reply structure

This is to be done after Reply rework (TODO: add reference to issue/pr)

pub struct Reply {
    /// The result of this Reply.
    // tags{rust.reply.sample}
    // tags{api.reply.get_sample}
    // tags{api.reply.get_error}
    // tags{api.reply.is_ok}
    pub sample: Result<Sample, Value>,
    /// The id of the zenoh instance that answered this Reply.
    // tags{rust.reply.replier_id, api.reply.replier_id.get}
    pub replier_id: ZenohId,
}
@milyin milyin added the release Part of the next release label Mar 10, 2024
@milyin milyin moved this to Backlog in Zenoh 1.0.0 release Mar 12, 2024
@milyin milyin removed the release Part of the next release label Mar 12, 2024
@milyin
Copy link
Contributor Author

milyin commented Mar 12, 2024

This issue is related to eclipse-zenoh/zenoh#709

@milyin milyin added the api sync Synchronize API with other bindings label Mar 12, 2024
@milyin
Copy link
Contributor Author

milyin commented May 29, 2024

more recent issue is #388

@milyin milyin closed this as completed May 29, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Zenoh 1.0.0 release May 29, 2024
@milyin milyin closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api sync Synchronize API with other bindings
Projects
Status: Done
Development

No branches or pull requests

1 participant