Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some configuration errors are silently ignored #1225

Closed
fuzzypixelz opened this issue Jul 5, 2024 · 1 comment
Closed

Some configuration errors are silently ignored #1225

fuzzypixelz opened this issue Jul 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@fuzzypixelz
Copy link
Member

Describe the bug

If make a an error in a configuration field such as scouting/multicast/connect Zenoh will act as if the field was null. The log shows zero warnings and zero errors.

To reproduce

  1. Start a Zenoh router with scouting/multicast/connect/router set to 42

System info
@fuzzypixelz fuzzypixelz added the bug Something isn't working label Jul 5, 2024
@fuzzypixelz
Copy link
Member Author

Fixed in #1224 by removing the #[serde(deserialize_with = "treat_error_as_none")] attributes. If I understand correctly this was the only instance where this issue occurred. We can reopen this otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fuzzypixelz