Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryableInfoType.complete is not properly used for queryables with identical key expressions on the same face. #1616

Open
DenisBiryukov91 opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@DenisBiryukov91
Copy link
Contributor

Describe the bug

QueryableInfoType.complete (in SessionContext and other structs) is not properly updated when declaring/undeclaring queryables if more than one queryable with the same key expression is declared for the same face. I.e on declaration of new queryable the .complete field is just overwritten to correspond to that of newly declared queryable, and when undeclaring queryable, this field is ignored if there are still remaining queryable with the same key expression.

To reproduce

The bug is easy to reproduce when using querier matching status/listener api introduced by #1591.

  1. declare incomplete queryable on "some/keyexpr"
  2. declare complete queryable on same keyexpr
  3. declare complete querier on same keyexpr
  4. undeclare complete queryable
  5. matching status for querier will be true (despite the fact that the only remaining queryable is incomplete)

System info

any

@DenisBiryukov91 DenisBiryukov91 added the bug Something isn't working label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants