Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding API rework #698

Closed
p-avital opened this issue Jan 29, 2024 · 3 comments · Fixed by #746 or #764
Closed

Encoding API rework #698

p-avital opened this issue Jan 29, 2024 · 3 comments · Fixed by #746 or #764
Assignees
@p-avital
Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) release Part of the next release

Comments

@p-avital
Copy link
Contributor

Describe the release item

The Encoding type has been too leaky of an abstraction. For the next release, we plan a breaking change around it, making it closer to how KeyExpr functions, allowing the user to interact more simply with it.
@p-avital p-avital added release Part of the next release breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) labels Jan 29, 2024
@p-avital p-avital self-assigned this Jan 29, 2024
@milyin milyin moved this to Backlog in Zenoh 1.0.0 release Jan 29, 2024
@p-avital
Copy link
Contributor Author

The new API shall abstract encodings as an integer-string pair, reserving a range for the Zenoh Project (size of the range TBD, presumably between 256 and 1024 values) and allowing users to define their own.

No attempt shall be made of shortening encodings passed by the user, nor of decompressing integers to the prefix they correspond to, apart from the REST plugin attempting to decompress in order to expose mime types.

@Mallets Mallets linked a pull request Feb 22, 2024 that will close this issue
Encoding encoder #746
Merged
@milyin
Copy link
Contributor

milyin commented Mar 11, 2024

The PR #764 should close this issue

@milyin milyin linked a pull request Mar 11, 2024 that will close this issue
Revised Encoding API and wire format #764
Merged
6 tasks
@milyin milyin moved this from Backlog to In review in Zenoh 1.0.0 release Mar 12, 2024
@Mallets
Copy link
Member

Mallets commented Mar 13, 2024

Closed by #764 which has been merged in https://github.com/eclipse-zenoh/zenoh/tree/protocol_changes.
It will be eventually merged in main.

@Mallets Mallets closed this as completed Mar 13, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Zenoh 1.0.0 release Mar 13, 2024
@Mallets Mallets mentioned this issue Mar 14, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-avital p-avital

Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encoding encoder eclipse-zenoh/zenoh
Revised Encoding API and wire format eclipse-zenoh/zenoh
3 participants
@milyin @Mallets @p-avital