You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summarizing discussion here: #656
We need to decide how to process optional internal structures in builder pattern. If structure is not optional, like Samplein PutBuilder, we can expose sample's encoding method from PutBuilder itself. But if the Sample is optional, like in GetBuilder, the setting of encoding should also add this sample.
Possible solutions:
GetBuilder::encoding implicitly adds Sample
GetBuilder provides some sub-builder, which explicilty adds default Sample and allows to set encoding
Do not expose methods for configuring optional interlal structures
something else?
The text was updated successfully, but these errors were encountered:
Discussed with @Mallets
methods with_payload and with_encoding should be used for get operation
Consider removing Value type and flatten encoding and payload everywhere.
It was decided to make builders API as flat as possible. Value is already deconstructed to payload and encoding, QoS is accessed through priority, express etc.
Describe the feature
Summarizing discussion here: #656
We need to decide how to process optional internal structures in builder pattern. If structure is not optional, like
Sample
inPutBuilder
, we can expose sample'sencoding
method fromPutBuilder
itself. But if theSample
is optional, like inGetBuilder
, the setting ofencoding
should also add this sample.Possible solutions:
GetBuilder::encoding
implicitly addsSample
GetBuilder
provides some sub-builder, which explicilty adds defaultSample
and allows to set encodingThe text was updated successfully, but these errors were encountered: