Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The clippy used in CI only includes Rust 1.72 lints #762

Closed
fuzzypixelz opened this issue Feb 26, 2024 · 0 comments · Fixed by #766
Closed

The clippy used in CI only includes Rust 1.72 lints #762

fuzzypixelz opened this issue Feb 26, 2024 · 0 comments · Fixed by #766
Labels
release Part of the next release

Comments

@fuzzypixelz
Copy link
Member

fuzzypixelz commented Feb 26, 2024

Describe the release item

More than 60 lints have been added to clippy since Rust 1.72. Many of them are relevant to the project currently (i.e. they throw warnings). They can be accessed by running cargo +stable clippy.

I think it makes sense for us to use Stable Rust lints in the CI. The downside is that someone might forget to add +stable when running clippy locally.

However, even though we use Rust 1.72 currently, dependent crates are free to compile zenoh with any toolchain > MSRV. Thus it makes sense to use Stable Rust lints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: Done
1 participant