-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'open' function without parameters for create session with default config #805
Comments
This is possible in C/C++, but for Rust the name should be different. This could be |
This could be implemented this way: let s = zenoh::open().wait()?;
...
let c = Config::from_file(file)?;
let s = zenoh::open().config(c).wait()?; I.e. make open function without parameters and add @Mallets what do you think? |
The proposal looks good to me and makes the API more coherent. |
On my side, I'm against, because I don't think we want the user to use default config. I don't know our user use cases at all, but is there some users that are really using default config in production? About coherence, I don't think having configuration as a required parameter is an inconsistency. Other methods also have required parameter, like keyexpr for |
Maybe |
According to latest discussion, |
@Mallets Is |
Describe the feature
@kydos wrote "I think we should have an overloaded zenoh::open() that does not take the config. Having to create a config just to pass it seems an avoidable step."
The text was updated successfully, but these errors were encountered: