Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable default features in zenoh-ext/examples #887

Open
YuanYuYuan opened this issue Apr 1, 2024 · 1 comment · Fixed by #888
Open

Enable default features in zenoh-ext/examples #887

YuanYuYuan opened this issue Apr 1, 2024 · 1 comment · Fixed by #888
Labels
bug Something isn't working

Comments

@YuanYuYuan
Copy link
Contributor

YuanYuYuan commented Apr 1, 2024 •
edited
Loading

Describe the bug

Similar issue as #854. If we run examples under zenoh-ext instead of workspace, then the default features of zenoh are missing to include.

To reproduce

cd zenoh-ext
cargo build --example z_pub_cache --example z_query_sub
cd ..
# Terminal 1
./target/debug/examples/z_pub_cache
# Terminal 2
./target/debug/examples/z_query_sub

Symptom: The querying side never receives a message.

System info

  • OS: Arch Linux x86_64
  • Kernel: 6.8.2-arch2-1
@YuanYuYuan YuanYuYuan added the bug Something isn't working label Apr 1, 2024
YuanYuYuan added a commit to ZettaScaleLabs/zenoh that referenced this issue Apr 1, 2024
@YuanYuYuan
Fix issue eclipse-zenoh#887
0529253
@YuanYuYuan YuanYuYuan mentioned this issue Apr 1, 2024
Merged
Mallets pushed a commit that referenced this issue Apr 3, 2024
@YuanYuYuan
Fix issue #887 (#888)
6799a92
Mallets added a commit that referenced this issue Apr 5, 2024
@Mallets
Revert "Fix issue #887 (#888)"
66d0ce9 
This reverts commit 6799a92.
@Mallets Mallets reopened this Apr 5, 2024
@Mallets
Copy link
Member

Mallets commented Apr 5, 2024

Similar to what done in zenoh where a different examples module has been created, also in zenoh-ext we should have a separate examples module to avoid cargo features conflict. See #905.

Mallets added a commit that referenced this issue Apr 5, 2024
@Mallets
Revert "Fix issue #887 (#888)" (#905)
9485061 
This reverts commit 6799a92.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #887 ZettaScaleLabs/zenoh
2 participants
@Mallets @YuanYuYuan