refactor: remove state from entities #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entities having having a reference to their state prevented to drop their callback when closing the session.
|
PR missing one of the required labels: {'dependencies', 'bug', 'internal', 'enhancement', 'new feature', 'breaking-change', 'documentation'} |
Mallets
approved these changes
Sep 12, 2024
|
@OlivierHecart the proposed changes look good to me but I'd like to have also your opinion. |
OlivierHecart
approved these changes
Sep 12, 2024
fuzzypixelz
pushed a commit
that referenced
this pull request
Sep 23, 2024
* refactor: remove state from entities Entities having having a reference to their state prevented to drop their callback when closing the session. * fix: fix unstable
fuzzypixelz
pushed a commit
that referenced
this pull request
Sep 23, 2024
* refactor: remove state from entities Entities having having a reference to their state prevented to drop their callback when closing the session. * fix: fix unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entities having having a reference to their state prevented to drop their callback when closing the session.