Close builder

[yellowhatter]

1. Close builder added with implementations for Session and Runtime
2. Remove ephemeral ports in tests

[github-actions]

PR missing one of the required labels: {'bug', 'documentation', 'dependencies', 'new feature', 'enhancement', 'internal', 'breaking-change'}

[yellowhatter]

Ci failed because of this: #1586

for TaskController::terminate_all_async change, repo search shows that there is no other projects using it through "internal" feature

[YuanYuYuan]

Hi @yellowhatter , here are my comments.

• These functions have no timeout, unlike their previous versions:
  • TransportManager::close
  • TerminatableTask::terminate
• Consider splitting the ephemeral port removal into a separate PR.
• Introducing two additional traits to create a concrete SessionCloseBuilder might be over engineering.
  Instead, let's focus on configuring the close behavior through a well-structured SessionCloseBuilder::new(config), just like we do in the other builders.
  This could include setting options like switching between a timeout-based blocking mode and a non-blocking mode.

[yellowhatter]

Hi, @YuanYuYuan

• These functions have no timeout, unlike their previous versions:

  • TransportManager::close
  • TerminatableTask::terminate

This is intentional. They used internal future timeout, and now I rely on top-level future timeout that can be modified by the user.

[Mallets]

Without entering the internal details of this particular PR, I think this kind of API addition should be coordinated with @milyin for all the bindings (C, C++, Python, etc.). Adding a timeout in the close builder/option is something we may want to expose as well in all other languages.

[yellowhatter]

Without entering the internal details of this particular PR, I think this kind of API addition should be coordinated with @milyin for all the bindings (C, C++, Python, etc.). Adding a timeout in the close builder/option is something we may want to expose as well in all other languages.

Sure. This change doesn't break the current bindings, and we will coordinate on it's support everywhere after this one get merged

[YuanYuYuan]

Yes. We could first discuss the use cases to see what options we want to expose. For instance, making the zenoh session terminate itself in a manner of nonblocking way if it has already been exit stage.

[yellowhatter]

for this: ZettaScaleLabs/rmw_zenoh#35

[milyin]

Looks good, but test for new functionality is needed

[yellowhatter]

three_node_combination_multicast test is failing on windows, as I can see this is a known flaky one

[yellowhatter]

Looks good, but test for new functionality is needed

added tests