ConfigProviderTest TCK bug

[Joseph-Cass]

Describe the bug

microprofile-config/tck/src/main/java/org/eclipse/microprofile/config/tck/ConfigProviderTest.java

Lines 84 to 91 in 795080d

	@Test
	public void testEnvironmentConfigSource() {
	Assert.assertNotNull(config.getValue("path", String.class));
	String value = System.getenv().get("MP_TCK_ENV_DUMMY");
	Assert.assertNotNull(value);
	Assert.assertEquals("dummy", value);
	Assert.assertEquals(value, config.getValue("mp.tck.env.dummy", String.class));
	}

testEnvironmentConfigSource() searches for a Config Property called "path". However, on Windows machines the environment variable "path" doesn't exist. The variable is called "Path".

This causes the Assert to fail.

[radcortez]

Interesting, I wonder how the TCK passes here: https://github.com/smallrye/smallrye-config/runs/1477581698

[Joseph-Cass]

Hmm I'm not sure either. I was guessing that the Microsoft Windows Server 2019 server which the GithHub Actions uses may have a "path" or "PATH" environment variable, but I can't tell for sure...

[Emily-Jiang]

@radcortez it depends on the Windows setting. Some Windows machine has PATH while others might have different variable name using different case. I think in the next release, we can improve the variable name mapping for env variable by ignoring the case as the fallback.

[Emily-Jiang]

I took a further look at this. Since the test in particular is to test the environment added, I think we can remove the line that causes the test unable to function in some OS.