Avoid unnecessary lock on UI thread with no model listeners #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szarnekow
reviewed
Nov 25, 2024
| @@ -563,6 +563,9 @@ protected <T> T internalReadOnly(IUnitOfWork<T, XtextResource> work, boolean isC | |||
| * changing while they run. To achieve this, we run the {@link IXtextModelListener}s on the UI thread. | |||
| */ | |||
| private void notifyModelListenersOnUiThread() { | |||
| if(modelListeners.isEmpty()) { | |||
There was a problem hiding this comment.
The modelListeners should not be accessed outside of a synchronization block. Please
mx990
force-pushed
the
documentLockerNotifyModelListeners
branch
from
7783fd5 to
8a80d14
Compare
|
can you please rebase |
…text#3251 Avoid unnecessarily aquiring a lock on the UI thread if there are no model listeners in the Xtext document. Signed-off-by: Martin Jobst <[email protected]>
mx990
force-pushed
the
documentLockerNotifyModelListeners
branch
from
8a80d14 to
da7fed8
Compare
|
@szarnekow is it OK to merge it now? |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessarily aquiring a lock on the UI thread if there are no model listeners in the Xtext document.
Closes #3251