Remove reliance on GHA target matrix in nightly builds #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Jinja for the same purpose. This allows for different Linux distributions to independently publish their artifacts when their own build and test was green. It also speeds up execution by not building all Docker images on every matrix iteration. Fixes edgedb/edgedb-pkg#4
|
It's probably easier to look at the generated |
Not completely. We still want to look into the possibility of caching the images to avoid building them on every run. |
|
Okay, but let's make atomic changes. This one is a big change in the workflows, let's make it separately from any other change. I also want to split Build from Test but didn't want to mangle this in one big diff. |
elprans
approved these changes
Jul 8, 2020
elprans
pushed a commit
that referenced
this pull request
Jul 8, 2020
Follow-up from #1518. The platform and platform_version properties were custom variables essentially. They are not built-in job properties and are unnecessary now after flattening the workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Jinja for the same purpose. This allows for different Linux distributions to independently publish their artifacts when their own build and test was green.
It also speeds up execution by not building all Docker images on every matrix iteration.
Fixes edgedb/edgedb-pkg#4