From 6bad8b9839fa6dd20ed89ab8366571b6677d6b9f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Wei=C3=9Fe?=
 <66256922+daniel-weisse@users.noreply.github.com>
Date: Mon, 2 Dec 2024 11:29:46 +0100
Subject: [PATCH] ci: ensure autoscaling test actuallly waits for all Pods to
 be ready (#3514)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
---
 .github/actions/e2e_autoscaling/action.yml | 25 +++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/.github/actions/e2e_autoscaling/action.yml b/.github/actions/e2e_autoscaling/action.yml
index bf787100b9..96c9907ed3 100644
--- a/.github/actions/e2e_autoscaling/action.yml
+++ b/.github/actions/e2e_autoscaling/action.yml
@@ -82,7 +82,30 @@ runs:
         KUBECONFIG: ${{ inputs.kubeconfig }}
       run: |
         worker_count=${{ steps.worker_count.outputs.worker_count }}
-        kubectl create -n default deployment nginx --image=nginx --replicas $(( 110 * (worker_count + 1) + 55 ))
+
+        cat <<EOF | kubectl apply -f -
+        kind: Deployment
+        apiVersion: apps/v1
+        metadata:
+          name: nginx
+          namespace: default
+        spec:
+          replicas: $(( 110 * (worker_count + 1) + 55 ))
+          strategy:
+            rollingUpdate:
+              maxUnavailable: 0 # Ensure "kubectl wait" actually waits for all pods to be ready
+          selector:
+            matchLabels:
+              app: nginx
+          template:
+            metadata:
+              labels:
+                app: nginx
+            spec:
+              containers:
+              - name: nginx
+                image: nginx
+        EOF
 
     - name: Wait for autoscaling and check result
       shell: bash