Skip to content

Commit

Permalink
moritz feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
elchead committed Nov 7, 2023
1 parent 33cc07e commit b850c4b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 11 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/e2e-test-tf-module.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,9 @@ jobs:
if: inputs.cliVersion != ''
shell: bash
run: |
mkdir build
curl -fsSL -o constellation https://github.com/edgelesssys/constellation/releases/download/${{ inputs.cliVersion }}/constellation-linux-amd64
chmod u+x constellation
PATH_ADD=$(pwd)
export PATH="$PATH:$PATH_ADD"
constellation version
# Do not spam license server from pipeline
chmod u+x ./constellation
./constellation version
sudo sh -c 'echo "127.0.0.1 license.confidential.cloud" >> /etc/hosts'
- name: Login to AWS (IAM + Cluster role)
Expand Down
10 changes: 5 additions & 5 deletions terraform/constellation-cluster/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ variable "node_groups" {
disk_type = string
zone = string
}))
description = "A map of node group names to node group configurations"
description = "A map of node group names to node group configurations."
validation {
condition = can([for group in var.node_groups : group.role == "control-plane" || group.role == "worker"])
error_message = "The role has to be 'control-plane' or 'worker'."
Expand Down Expand Up @@ -66,21 +66,21 @@ variable "aws_config" {
iam_instance_profile_worker_nodes = string
iam_instance_profile_control_plane = string
})
description = "The cluster config for AWS"
description = "The cluster config for AWS."
default = null
}

variable "image" {
type = string
description = "The node image reference or semantical release version"
description = "The node image reference or semantical release version."
}

variable "kubernetes_version" {
type = string
description = "Kubernetes version"
description = "Kubernetes version."
}

variable "microservice_version" {
type = string
description = "Microservice version"
description = "Microservice version."
}

0 comments on commit b850c4b

Please sign in to comment.