From b850c4b1bca4cbf4e30c12ea97307c69bdbffb5d Mon Sep 17 00:00:00 2001 From: Adrian Stobbe Date: Tue, 7 Nov 2023 12:21:56 +0100 Subject: [PATCH] moritz feedback --- .github/workflows/e2e-test-tf-module.yml | 8 ++------ terraform/constellation-cluster/variables.tf | 10 +++++----- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/.github/workflows/e2e-test-tf-module.yml b/.github/workflows/e2e-test-tf-module.yml index 1ddcfd16dd..bd4949b8f4 100644 --- a/.github/workflows/e2e-test-tf-module.yml +++ b/.github/workflows/e2e-test-tf-module.yml @@ -148,13 +148,9 @@ jobs: if: inputs.cliVersion != '' shell: bash run: | - mkdir build curl -fsSL -o constellation https://github.com/edgelesssys/constellation/releases/download/${{ inputs.cliVersion }}/constellation-linux-amd64 - chmod u+x constellation - PATH_ADD=$(pwd) - export PATH="$PATH:$PATH_ADD" - constellation version - # Do not spam license server from pipeline + chmod u+x ./constellation + ./constellation version sudo sh -c 'echo "127.0.0.1 license.confidential.cloud" >> /etc/hosts' - name: Login to AWS (IAM + Cluster role) diff --git a/terraform/constellation-cluster/variables.tf b/terraform/constellation-cluster/variables.tf index c477da0b60..6a5bd558b1 100644 --- a/terraform/constellation-cluster/variables.tf +++ b/terraform/constellation-cluster/variables.tf @@ -16,7 +16,7 @@ variable "node_groups" { disk_type = string zone = string })) - description = "A map of node group names to node group configurations" + description = "A map of node group names to node group configurations." validation { condition = can([for group in var.node_groups : group.role == "control-plane" || group.role == "worker"]) error_message = "The role has to be 'control-plane' or 'worker'." @@ -66,21 +66,21 @@ variable "aws_config" { iam_instance_profile_worker_nodes = string iam_instance_profile_control_plane = string }) - description = "The cluster config for AWS" + description = "The cluster config for AWS." default = null } variable "image" { type = string - description = "The node image reference or semantical release version" + description = "The node image reference or semantical release version." } variable "kubernetes_version" { type = string - description = "Kubernetes version" + description = "Kubernetes version." } variable "microservice_version" { type = string - description = "Microservice version" + description = "Microservice version." }