caa: support peerpods in node-installer (again) #1043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
force-pushed
the
burgerdev/revert-revert
branch
from
0e9248a to
aa53900
Compare
You mean you want to keep the fixup commits? Changes lgtm, didn't test yet. |
Sorry, I meant to say that I want to fixup the fixups and then rebase. We keep the history, but have a few intermediate commits that won't pass e2e tests. |
burgerdev
force-pushed
the
burgerdev/revert-revert
branch
from
aa53900 to
3caff7b
Compare
katexochen
approved these changes
Dec 5, 2024
burgerdev
force-pushed
the
burgerdev/revert-revert
branch
2 times, most recently
from
92e2e90 to
b373dfa
Compare
This reverts commit da32110.
This reverts commit 22ba580.
This reverts commit 9438bdb.
…d config" This reverts commit 3ecbce3.
This reverts commit 39e8274.
…SNP" This reverts commit 36c6293.
This reverts commit 5abaf33.
This reverts commit 85fe4dc.
This reverts commit fde72c2.
This reverts commit ee335a7.
This reverts commit a475b4a.
…PEER-SNP"" This reverts commit 63b147d.
burgerdev
force-pushed
the
burgerdev/revert-revert
branch
from
b373dfa to
d1b8911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reapplies most of the commits that moved CAA into the node-installer. I've split the commits into the clean reapplies and dedicated
fixupcommits where I found problems in the original commits. These include:iptablesin the CAA container image.apply-runtimetarget, which is the point when we know the namespace to apply them to.The last commit adapts the peer-pods e2e test to the prior changes, which means that the peer-pods workflow is not expected to work for the last 3 commits or so. We could squash this PR, but I think I'd prefer to have the history intact.