-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add demo for workload secrets #1045
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
bc385a2
to
40c593a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but we need to deal with the password before merging.
Awesome!
We then might want to have a dedicated "Tasks" section in the docs that goes more in-depth with certain operations such as "Mount encrypted volumes, "recover the coordinator", ... Let me know what you think:-) |
We could also consider the https://diataxis.fr/ approach for structuring. I'd defer this discussion for the PR here, though. |
40c593a
to
73fcc13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, only few nits
73fcc13
to
c22e55e
Compare
This adds a demo application running a MySQL server with an encrypted volume mount, similar to the
volume-tester
. For this, thecryptsetup
init container uses the workload secret to set up a LUKS partition that is mounted to/var/lib/mysql
. The demo is also provided as a release artifact asmysql-demo.yml
.