Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/image: use erofs-utils' --hard-dereference flag #1096

Merged
merged 1 commit into from
Dec 20, 2024
Merged

nixos/image: use erofs-utils' --hard-dereference flag #1096

merged 1 commit into from
Dec 20, 2024
+6 −0

Conversation

katexochen
Copy link
Member

to make image builds reproducible between systems with nix store optimization enables/disabled.

@katexochen
nixos/image: use erofs-utils' --hard-dereference flag
d4b3a09 
to make image builds reproducible between systems with nix store optimization enables/disabled.

Signed-off-by: Paul Meyer <[email protected]>
@katexochen katexochen added the changelog PRs that should be part of the release notes label Dec 20, 2024
@katexochen
Copy link
Member Author

Please test with

nix build .#image-podvm --builders "" &&
nix build .#image-podvm --builders "" --rebuild && 
[[ $(sha256sum result/image-podvm-gpu_1-rc1.raw | cut -d' ' -f1) == 6423bb295dae82f73d4eea86d9d8a49b0be73d192f1b7bab5b6c009e35363b97 ]]

msanft
msanft approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested reproducibility with the command suggested by @katexochen. Works!

3u13r
3u13r approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@3u13r 3u13r left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on both my systems

@katexochen katexochen merged commit e28d2af into main Dec 20, 2024
14 checks passed
@katexochen katexochen deleted the p/erofs-deref branch December 20, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft approved these changes

@3u13r 3u13r 3u13r approved these changes

@burgerdev burgerdev burgerdev approved these changes

Assignees
No one assigned
Labels
changelog PRs that should be part of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@katexochen @burgerdev @3u13r @msanft