ci: embed prod policy settings on release #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that's a good idea. |
Excellent suggestion, let me add that to the proposal. |
burgerdev
force-pushed
the
burgerdev/release-policy
branch
from
c75eda4 to
54e3bfd
Compare
katexochen
reviewed
Feb 20, 2024
malt3
approved these changes
Feb 21, 2024
burgerdev
force-pushed
the
burgerdev/release-policy
branch
3 times, most recently
from
d995ef8 to
2771f54
Compare
This commit blesses the Microsoft fork of the Kata Containers policy and settings. Why not ours? * Any divergence from upstream configs risks security relevant divergence and would need continuous justification. * We can contribute missing policy features upstream, if needed. Why not kata-containers/kata-containers? * We assume that the Microsoft fork is customized to the AKS environment that we're targeting, and we want to stay compatible with that. * The genpolicy tool and its config are not compatible across minor versions (e.g., a policy generated from Kata head today is not accepted by the Kata Agent available in the AKS preview today).
Introduces a new parameter for some just targets that allows overriding the nix rule used to build the cli. The dev variant stays the default, while the release variant is used for e2e testing.
burgerdev
force-pushed
the
burgerdev/release-policy
branch
from
2771f54 to
49dc9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit blesses the Microsoft fork of the Kata Containers policy and settings.
Why not ours?
Why not kata-containers/kata-containers?