Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treefmt: add vale #281

Merged
merged 4 commits into from
Mar 28, 2024
Merged

treefmt: add vale #281

merged 4 commits into from
Mar 28, 2024

Conversation

katexochen
Copy link
Member

@katexochen katexochen commented Mar 26, 2024

Note: In the current way we configure vale, suggestions/warnings won't cause CI to fail (and are thus invisible).
Currently, this affects only the following two rules:

Microsoft.SentenceLength 
Microsoft.We

Note 2: The styles vendored in this PR are copied from another repo and outdated. I'm working on packaging things to devendor and keep the styles up to date.

Signed-off-by: Paul Meyer <[email protected]>
@katexochen katexochen added the no changelog PRs not listed in the release notes label Mar 26, 2024
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://edgelesssys.github.io/contrast/pr-preview/pr-281/
on branch gh-pages at 2024-03-26 16:32 UTC

Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
@katexochen katexochen marked this pull request as ready for review March 27, 2024 13:14
@katexochen katexochen requested a review from m1ghtym0 March 27, 2024 13:14
@katexochen katexochen changed the title docs: add vale treefmt: add vale Mar 27, 2024
@m1ghtym0
Copy link
Member

Note: In the current way we configure vale, suggestions/warnings won't cause CI to fail (and are thus invisible). Currently, this affects only the following two rules:

Microsoft.SentenceLength 
Microsoft.We

Both things are not critical IMO.

Note 2: The styles vendored in this PR are copied from another repo and outdated. I'm working on packaging things to devendor and keep the styles up to date.

Sounds good!

@katexochen katexochen merged commit 27003e5 into main Mar 28, 2024
8 checks passed
@katexochen katexochen deleted the p/docs-vale branch March 28, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants