Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add basics/coco #345

Merged
merged 1 commit into from
Apr 18, 2024
Merged

docs: add basics/coco #345

merged 1 commit into from
Apr 18, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Apr 17, 2024

Adding a basic introduction to Confidential Containers to the documentation.

@burgerdev burgerdev added the documentation Improvements for user docs label Apr 17, 2024
Copy link

github-actions bot commented Apr 17, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-18 07:56 UTC

@burgerdev burgerdev force-pushed the burgerdev/docs-coco branch from 317127d to d645025 Compare April 17, 2024 18:34
@burgerdev burgerdev marked this pull request as ready for review April 17, 2024 18:36
@burgerdev burgerdev requested a review from katexochen as a code owner April 17, 2024 18:36
@burgerdev burgerdev requested a review from m1ghtym0 April 17, 2024 18:37
Co-authored-by: Paul Meyer <[email protected]>
@burgerdev burgerdev force-pushed the burgerdev/docs-coco branch from c2695ad to 497336a Compare April 18, 2024 06:40
@burgerdev burgerdev requested a review from katexochen April 18, 2024 06:42
@katexochen
Copy link
Member

Is it just me or isn't the preview updated correctly?

@burgerdev
Copy link
Contributor Author

I see the updated text on https://edgelesssys.github.io/contrast/pr-preview/pr-345/basics/confidential-containers.

@katexochen
Copy link
Member

Caching..

Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's give @m1ghtym0 a chance to take a look before merging.

@burgerdev burgerdev merged commit 6499516 into main Apr 18, 2024
6 checks passed
@burgerdev burgerdev deleted the burgerdev/docs-coco branch April 18, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements for user docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants