Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update graphics #586

Merged
merged 3 commits into from
Jun 18, 2024
Merged

docs: update graphics #586

merged 3 commits into from
Jun 18, 2024

Conversation

m1ghtym0
Copy link
Member

  • Add concept design to readme and intro
  • Update components with black instead of purple on green
  • Backport both to 0.7

@m1ghtym0 m1ghtym0 added no changelog PRs not listed in the release notes documentation Improvements for user docs labels Jun 17, 2024
@m1ghtym0 m1ghtym0 requested a review from katexochen as a code owner June 17, 2024 08:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-18 07:19 UTC

@katexochen
Copy link
Member

There is also https://github.com/edgelesssys/contrast/blob/main/docs/docs/_media/personas.svg with the purple on green.

@katexochen katexochen removed the documentation Improvements for user docs label Jun 17, 2024
katexochen
katexochen approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to comply with the style guidelines now. I'm not a fan of the black boxes, looks quite depressive and also a bit hard to read. Maybe we can just use white in the future?

katexochen
katexochen approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@m1ghtym0 m1ghtym0 merged commit 391a7d4 into main Jun 18, 2024
9 checks passed
@m1ghtym0 m1ghtym0 deleted the m/docs/graphics branch June 18, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1ghtym0 @katexochen