Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: use random key for intermediate CA #732

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

burgerdev
Copy link
Contributor

When we introduced Coordinator recovery, we decided to derive all key material deterministically from the seed. This implies that whoever owns the seed can derive these keys offline, too. However, since the seed needs to be held by the workload owner for recovery, the data owner can't trust in the mesh CA cert without trusting the workload owner.

This PR reverts to a random mesh/intermediate key, which is inaccessible to the workload owner. The trade-off is that the mesh key changes after recovery, and all workloads need to be restarted in order to pick up this change.

@burgerdev burgerdev added the bug fix Fixing a user facing bug label Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-17 07:33 UTC

@burgerdev burgerdev force-pushed the burgerdev/intermediate branch from a8623e9 to 91b1b0a Compare July 17, 2024 06:51
@burgerdev burgerdev marked this pull request as ready for review July 17, 2024 06:51
@burgerdev burgerdev requested a review from katexochen as a code owner July 17, 2024 06:51
@katexochen katexochen requested a review from Freax13 July 17, 2024 07:00
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

e2e/openssl/openssl_test.go Show resolved Hide resolved
@burgerdev burgerdev force-pushed the burgerdev/intermediate branch from 91b1b0a to 587d863 Compare July 17, 2024 07:19
@burgerdev burgerdev merged commit 85f44f1 into main Jul 17, 2024
11 checks passed
@burgerdev burgerdev deleted the burgerdev/intermediate branch July 17, 2024 07:33
@edgelessci
Copy link
Contributor

Successfully created backport PR for release/v0.8:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v0.8 bug fix Fixing a user facing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants