kata: use restrictive default policy #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
requested review from
msanft and
Freax13
and removed request for
katexochen
|
iirc the 0003 patch is already a modified version of the upstream PR, isn't it? |
|
It sure looks different :) Should I then just merge the two? |
|
idk, both fine for me. Costs nothing to add a patch and provide some history, might also be easier to roll-back if needed. Whatever you do, please document it properly (would also be nice if you could try to improve the comment of the existing patch), as it is obviously not covering all relevant points. |
msanft
approved these changes
Jul 23, 2024
packages/by-name/kata/kata-runtime/0004-runtime-set-mrconfigid-if-running-in-TDX.patch
Outdated
Show resolved
Hide resolved
Yes, I had to resolve some merge conflicts, so the bug was introduced by me. |
Freax13
approved these changes
Jul 24, 2024
Co-authored-by: Moritz Sanft <[email protected]>
|
Everything addressed. @katexochen please check the patch docstring. |
katexochen
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in patch 0003 which causes wrong arguments for QEMU and thus prevents starting VMs
- patch 0004 in this PR fixes that bug. Since 0003 corresponds to an open upstream PR, I'd rather not integrate the patch here into 0003, so that we have a clear history of the modifications.There was another bug in the upstream PR, which assumed hex encoding for MRCONFIGID where it should have been base64.
I amended 0003 to fix these, and subsequently changed to a restrictive default policy.