cli: factor out genpolicy #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
force-pushed
the
burgerdev/rules
branch
4 times, most recently
from
f94bbff to
74967b6
Compare
burgerdev
force-pushed
the
burgerdev/rules
branch
from
74967b6 to
b8c37e8
Compare
Freax13
reviewed
Jul 30, 2024
Freax13
reviewed
Jul 30, 2024
burgerdev
force-pushed
the
burgerdev/rules
branch
from
b8c37e8 to
70ff669
Compare
burgerdev
added
no changelog
burgerdev
force-pushed
the
burgerdev/rules
branch
from
70ff669 to
7e2a615
Compare
|
Hey folks! I rewrote the PR - it's now fully backwards compatible. |
katexochen
reviewed
Aug 1, 2024
Freax13
approved these changes
Aug 1, 2024
katexochen
approved these changes
Aug 1, 2024
Co-authored-by: Tom Dohrmann <[email protected]> Co-authored-by: Paul Meyer <[email protected]>
burgerdev
force-pushed
the
burgerdev/rules
branch
from
856790c to
9163c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the invocation of the genpolicy tool into its own package, to reduce the amount of code in
cmdand allow for better testing.This new package also knows which settings are appropriate for which platform. We would like to keep backward compatibility with respect to the cli flags for rules and settings. This is why the config is separate from the runner: the CLI gets the default config, (maybe) writes it to the files, and then starts the runner with the files.