contrast: use kata-specific rules, settings and binary for bare-metal platforms #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
reviewed
Sep 4, 2024
packages/by-name/kata/kata-runtime/0005-genpolicy-deny-UpdateEphemeralMountsRequest.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0005-genpolicy-deny-UpdateEphemeralMountsRequest.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0007-genpolicy-enable-sysctl-checks.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0007-genpolicy-enable-sysctl-checks.patch
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0007-genpolicy-enable-sysctl-checks.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0013-genpolicy-allow-image_guest_pull.patch
Outdated
Show resolved
Hide resolved
katexochen
force-pushed
the
p/bm-policy
branch
from
e0cf761 to
8a1eca4
Compare
katexochen
changed the title
katexochen
force-pushed
the
p/bm-policy
branch
2 times, most recently
from
65f1c89 to
db98d6b
Compare
burgerdev
reviewed
Sep 10, 2024
burgerdev
reviewed
Sep 10, 2024
packages/by-name/kata/kata-runtime/0013-genpolicy-allow-image_guest_pull.patch
Outdated
Show resolved
Hide resolved
burgerdev
reviewed
Sep 16, 2024
There was a problem hiding this comment.
I think I addressed all the feedback so far. Patches are likely better reviewed in https://github.com/kata-containers/kata-containers/compare/3.8.0...burgerdev:kata-containers:p/bm-policy?expand=1.
@katexochen There are three commits in this branch with the same name. Did you mean to keep them separate, or to squash them?
packages/by-name/kata/kata-runtime/0007-genpolicy-enable-sysctl-checks.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0005-genpolicy-deny-UpdateEphemeralMountsRequest.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0007-genpolicy-enable-sysctl-checks.patch
Outdated
Show resolved
Hide resolved
burgerdev
force-pushed
the
p/bm-policy
branch
from
1f2e193 to
4b69f83
Compare
Freax13
reviewed
Sep 17, 2024
packages/by-name/kata/kata-runtime/0007-genpolicy-enable-sysctl-checks.patch
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0007-genpolicy-enable-sysctl-checks.patch
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0009-genpolicy-harden-args-and-env.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0009-genpolicy-harden-args-and-env.patch
Outdated
Show resolved
Hide resolved
packages/by-name/kata/kata-runtime/0013-genpolicy-allow-image_guest_pull.patch
Outdated
Show resolved
Hide resolved
burgerdev
reviewed
Sep 17, 2024
burgerdev
force-pushed
the
p/bm-policy
branch
from
afc537d to
f08623d
Compare
On this PR? I only see 3 commit that share a prefix. Feel free to adapt commit structure as it makes sense. |
|
Sorry, should have read more than 4 words. I'm gonna squash this now - any more opinions on this PR? |
Freax13
approved these changes
Sep 23, 2024
|
lgtm |
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
burgerdev
force-pushed
the
p/bm-policy
branch
from
f08623d to
f2a96b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.