Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Azure cluster setup #873

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

blenessy
Copy link
Contributor

It is not necessary to create secondary node pool if you create the AKS with KataCcIsolation enabled.

It is not necessary to create secondary node pool if you
create the AKS with KataCcIsolation enabled.
@katexochen katexochen requested review from Freax13 and removed request for katexochen September 16, 2024 06:54
Copy link
Contributor

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This looks good to me.

Can you update create-coco-aks.sh script accordingly?

@blenessy
Copy link
Contributor Author

Glad to help @Freax13 ! Updated the script in question and scripts.nix accordingly.

@Freax13 Freax13 added the no changelog PRs not listed in the release notes label Sep 17, 2024
Copy link
Contributor

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :shipit:!

CI is failing because our workflows apparently don't work well with contributors outside the edgelesssys org. I ran the default target and the e2e openssl target manually; everything worked as expected.

@Freax13 Freax13 merged commit b26db14 into edgelesssys:main Sep 17, 2024
7 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants