Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu-static: add patches for VFIO support on SNP #927

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Oct 11, 2024

Upstream QEMU can't launch SNP VMs with VFIO devices. Apply the patches from this patch series: https://patchwork.kernel.org/project/kvm/cover/[email protected]/. We also need another patch to support large devices (such as GPUs).

Note that I didn't yet test GPU support with the binary built by qemu-static, but I did test the patches on a separate non-nix QEMU build. We might need additional changes to make GPU support work for Contrast.

@Freax13 Freax13 requested a review from katexochen as a code owner October 11, 2024 11:18
@Freax13 Freax13 added the no changelog PRs not listed in the release notes label Oct 12, 2024
@katexochen
Copy link
Member

Note that I didn't yet test GPU support with the binary built by qemu-static, but I did test the patches on a separate non-nix QEMU build. We might need additional changes to make GPU support work for Contrast.

So this PR is still work in progress?

@Freax13
Copy link
Contributor Author

Freax13 commented Oct 15, 2024

My idea was to merge this now and test it later, but I'm also fine with delaying this until we can actually test it. I just wanted to make sure we don't lose this work while waiting for other stuff.

@Freax13 Freax13 marked this pull request as draft October 15, 2024 13:59
@burgerdev burgerdev marked this pull request as ready for review December 16, 2024 08:05
@burgerdev burgerdev requested a review from msanft December 16, 2024 08:06
@burgerdev burgerdev added this to the v1.3.0 milestone Dec 16, 2024
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say too much regarding the individual patches, but I can vouch for the change working.

Upstream QEMU can't launch SNP VMs with VFIO devices. Apply the patches
from this patch series:
https://patchwork.kernel.org/project/kvm/cover/[email protected]/
We also need another patch to support large devices (such as GPUs).
@msanft msanft merged commit 6c6fbaf into main Dec 19, 2024
11 checks passed
@msanft msanft deleted the tom/vfio-snp branch December 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants