From 7440f70918fefc2b52edefef23771e8a88e50616 Mon Sep 17 00:00:00 2001 From: Tom Dohrmann Date: Wed, 28 Aug 2024 09:54:38 +0200 Subject: [PATCH] ci: don't fail fast The matrix strategy defaults to failing fast: If any one of the test cases fails all other cases get cancelled as well. The problem with this is that sometimes tests fail not because the code is bad, but because the test is flaky. In an ideal world, we'd make the tests less flaky, but until then we shouldn't abort all other tests in the matrix. The advantage of not failing fast is that when we inevitably have to manually push the re-run button, we don't have to wait for all test cases to complete, but only for the one that failed. --- .github/workflows/e2e_kubernetes.yaml | 1 + .github/workflows/e2e_openssl_baremetal.yml | 1 + .github/workflows/e2e_regression.yml | 1 + 3 files changed, 3 insertions(+) diff --git a/.github/workflows/e2e_kubernetes.yaml b/.github/workflows/e2e_kubernetes.yaml index 40d96e6413..f49ada8b2a 100644 --- a/.github/workflows/e2e_kubernetes.yaml +++ b/.github/workflows/e2e_kubernetes.yaml @@ -26,6 +26,7 @@ jobs: strategy: matrix: test_name: [servicemesh, openssl, policy, workloadsecret] + fail-fast: false runs-on: ubuntu-22.04 permissions: diff --git a/.github/workflows/e2e_openssl_baremetal.yml b/.github/workflows/e2e_openssl_baremetal.yml index ab94c6e34d..412b8a44cd 100644 --- a/.github/workflows/e2e_openssl_baremetal.yml +++ b/.github/workflows/e2e_openssl_baremetal.yml @@ -24,6 +24,7 @@ jobs: matrix: test_name: [servicemesh, openssl, policy, workloadsecret] tee: [SNP, TDX] + fail-fast: false runs-on: labels: ${{ matrix.tee }} diff --git a/.github/workflows/e2e_regression.yml b/.github/workflows/e2e_regression.yml index 21bcf87125..5a5eb3e40b 100644 --- a/.github/workflows/e2e_regression.yml +++ b/.github/workflows/e2e_regression.yml @@ -34,6 +34,7 @@ jobs: - getdents - genpolicy - regression + fail-fast: false steps: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: ./.github/actions/setup_nix