Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: code (2/2) #18

Open
iain-anderson opened this issue Oct 18, 2019 · 0 comments
Open

Review: code (2/2) #18

iain-anderson opened this issue Oct 18, 2019 · 0 comments
Assignees

Comments

@iain-anderson
Copy link
Contributor

iain-anderson commented Oct 18, 2019

  • The time taken in the main loop (call to UA_sleep_ms) should be configurable with an entry in the [Driver] config section

  • Also in this loop, the releases and re-acquisitions of the mutex could allow the structure to be changed while we are iterating it. The mutex should be held for the whole pass. If the calls to UA_Client_runAsync take significant time, create a new list of clients which require the call, and iterate this outside of the mutexed section.

  • opcua_driver.conn_length and ua_conn_addr_status.length should be unsigned. Use iterator variables of the same type in for() loops which reference them

@alexmcminn alexmcminn self-assigned this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants