Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subhook submodule is 404 #169

Open
UnicodeMan opened this issue Nov 15, 2024 · 3 comments
Open

subhook submodule is 404 #169

UnicodeMan opened this issue Nov 15, 2024 · 3 comments

Comments

@UnicodeMan
Copy link

UnicodeMan commented Nov 15, 2024

git clone https://github.com/edk2-porting/edk2-rk3588.git --recurse-submodules
fails to clone https://github.com/Zeex/subhook/ submodule, when manually accessing the submodule through web browser, Github returns 404.
Therefore building edk2 firmware fails.

@binarymaster
Copy link

Same problem as in microsoft/mu_basecore#1208

It should be possible to fix by replacing URL https://github.com/Zeex/subhook with https://github.com/tianocore/edk2-subhook

@binarymaster
Copy link

This has been addressed in upstream, git submodule should be updated.

binarymaster added a commit to binarymaster/edk2-rk3588 that referenced this issue Nov 15, 2024
@bicebird
Copy link

Tried building for rock5b plus with this branch but build.py failed with error 7000
(sorry if not the right place / not enough detail as still getting my head around github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants