Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When items are merged, item history doesn't always get preserved. #84

Open
bjohas opened this issue Apr 15, 2022 · 0 comments
Open

When items are merged, item history doesn't always get preserved. #84

bjohas opened this issue Apr 15, 2022 · 0 comments

Comments

@bjohas
Copy link
Collaborator

bjohas commented Apr 15, 2022

Currently the extension saves the item history when the items are actually merged. However, this leads to the following issue: If the user uses the dropdowns, the relevant item is adjusted immediately, which removes that field from the 'history'. For example:

  • Create item 1, put '1' into the extra field
  • Create item 2, put '2' into the extra field
  • Merge items. In the dialogue, select Item 1.
  • In the dropdowns, change extra from '1' to '2'.
  • Press merge
    Result: Item history contains 'Extra: 2' for both items.

Proposal:

  1. When the user initiates the merge, do 'save item details to note' for both items.
  2. Once the items have been merged, retrieve the two most recent 'item details' and restore the extra field as a merged extra field.

Note:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant