Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any issue with dropping curl dependency? #62

Open
zanerock opened this issue Jan 4, 2015 · 4 comments
Open

Any issue with dropping curl dependency? #62

zanerock opened this issue Jan 4, 2015 · 4 comments

Comments

@zanerock
Copy link

zanerock commented Jan 4, 2015

It seems possible to rewrite (something I'd be happy to contribute to) to use PHP streams rather than rely on curl for the HTTP requests. This has the advantage of actually using (rather than ignoring) HTTPS host verification. Also, it seems to me that vanilla Composer (which Pest supports) is incompatible with curl systems. At least on my setup, if PHP is compiled with curl, (the latest?) composer either fails to install (if --with-curl-wrappers included) or fails at runtime (if 'wrappers' left out, but --with-curl left in).

@zanerock
Copy link
Author

zanerock commented Jan 4, 2015

After looking into it more, the curl backed method will verify the HTTPS certs if properly configured, in which case the solution might be to conditionally or at least optionally enable the HTTPS checks for curl. Still, might be simpler to remove curl dependency (?).

@zuk
Copy link
Member

zuk commented Feb 25, 2015

Sounds good to me. Pest is not getting the love it needs lately. Would you be interested in jumping on as a maintainer/contributor?

@zanerock
Copy link
Author

Yes, I would. I'm integrating pest in a number of projects.

@zuk
Copy link
Member

zuk commented Mar 1, 2015

Okay you should now have full access to the Pest repo.
https://github.com/djsipe is the other maintainer, but I don't think he's
been too active lately. Judging from your comments, it sounds like you know
what you're doing so I'll leave it to your judgement to decide what changes
to push without breaking things for everyone else who uses the library.

On Sat, Feb 28, 2015 at 12:13 PM, Zane Rockenbaugh <[email protected]

wrote:

Yes, I would.


Reply to this email directly or view it on GitHub
#62 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants