Update common #417
Merged
Update common #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was recently introduced in common for routing, but not needed in the Android app as we 'protect' the underlying proxyguard socket using the FD.
jwijenbergh
force-pushed
the
update-common
branch
from
be1f5f5 to
8503579
Compare
dzolnai
approved these changes
Apr 3, 2024
|
Can you rebase your PR to fix the failing tests @jwijenbergh? |
jwijenbergh
force-pushed
the
update-common
branch
from
d774c91 to
39813f0
Compare
jwijenbergh
force-pushed
the
update-common
branch
from
594a34f to
7ec4d1a
Compare
|
Done! Also bumped common again :) |
|
And it's green! 🎉 Merging |
|
Thanks Dániel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates common, building and change file