Update UI tests #419
Merged
Update UI tests #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dzolnai
commented
Apr 5, 2024
dzolnai
commented
- They were not running on API level 34 because of a missing permission declaration in the testing libraries. Updating the libraries fixed this.
- The eduID website and Chrome introduction screen changed a bit
- I have moved the browser preparation code to a common class, to reduce duplication
- I have also found a timing issue, where sometimes the common cookie would be canceled before the reply was sent, aborting the process of adding a new server
Fix UI tests, update dependencies and GH Actions runner
dzolnai
force-pushed
the
feature/ui_tests
branch
from
aef341e to
ef7eded
Compare
dima-ko
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.