Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrange ownership transfer for api_admin and api-manager #365

Closed
robrap opened this issue Jul 20, 2023 · 8 comments
Closed

Arrange ownership transfer for api_admin and api-manager #365

robrap opened this issue Jul 20, 2023 · 8 comments

Comments

@robrap
Copy link
Contributor

robrap commented Jul 20, 2023

A/C:

  • Identify an appropriate team willing to take on ownership of this Django app
  • Write up a transfer plan
  • Execute the plan

Context:

  • According to the ownership spreadsheet, arch-bom owns openedx/core/djangoapps/api_admin.
  • Arch-bom does not monitor any API access requests.
  • Enterprise monitors these requests for enterprise partners.
  • Internal users sometimes make these requests.
    • No one knows who own the process for approval, not what the process should be.
    • There have been way too many Slack threads on this. Here is a recent Slack thread that points to at least one older thread.
  • HelpDesk has been approving on an adhoc basis after repeated discussions in Slack.

Questions:

  • What is the fastest way for @robrap/arch-bom to no longer be pinged on these requests?
  • Kelly raised security concerns when @robrap proposed auto-approval for internal users. Are there real concerns? Should Security WG or CyberSecurity weigh in?
  • Can Enterprise own the whole thing? Presumably whatever process they use to ensure partners know how to use this responsibly could be replicated for internal users, if anything is done at all.
  • Would HelpDesk be willing to implement the approval long-term if they knew what the process was?
@robrap robrap added this to Arch-BOM Jul 20, 2023
@robrap robrap converted this from a draft issue Jul 20, 2023
@robrap
Copy link
Contributor Author

robrap commented Jul 20, 2023

@davidjoy: Maybe you could take this from an ownership perspective to start? I created a ticket just to capture the information.

@jmbowman jmbowman moved this to Prioritized in Arch-BOM Jul 24, 2023
@jmbowman jmbowman changed the title Resolve ownership and process questions for api_admin Arrange ownership transfer for api_admin Sep 13, 2023
@jmbowman jmbowman moved this from Prioritized to Groomed in Arch-BOM Sep 13, 2023
@robrap
Copy link
Contributor Author

robrap commented Sep 20, 2023

A similar topic is ownership of api-manager. I just created edx/api-manager#233, as an example of what the owner might do.

  • Should api-manager ownership be considered as part of this ticket, or would we want a separate "arrange ownership transfer" ticket for it?
  • Part of the initial thinking around this ownership was that the architecture team should provide guidance/governance around the decision making for key infrastructure like this. Is it possible to split guidance from long-term ownership? Do we want to ensure that the owning team is also equipped to have the vision and guidance for the infrastructure (e.g. knows when it should change, or be retired, or be enhanced, etc.)? We might ask a similar set of questions about the event-bus. Note that MFEs got off the ground with the arch squad, but now there is a WG and other teams that are responsible for that moving forward.

@davidjoy
Copy link

FYI, I haven't been able to make any progress here, unfortunately, what with getting pulled into other projects.

@robrap
Copy link
Contributor Author

robrap commented Sep 20, 2023

@davidjoy: I just unassigned this from you. I've assumed at this point that you are on other things, and this is on our groomed backlog. You are welcome to assign this to yourself if you ever want to move it to in-progress, but otherwise, I don't think it makes sense to make you a blocker on any of the arch-bom tickets. Let me know if you disagree.

@robrap
Copy link
Contributor Author

robrap commented Oct 12, 2023

[inform] The api-manager ownership question has come up recently due to ongoing TNL work. We may want to consider re-prioritizing this as P2 (blocking other teams). See Slack thread. FYI: @jmbowman

@robrap robrap changed the title Arrange ownership transfer for api_admin Arrange ownership transfer for api_admin and api-manager Oct 13, 2023
@dianakhuang dianakhuang self-assigned this Oct 18, 2023
@robrap
Copy link
Contributor Author

robrap commented Nov 17, 2023

Moving this to backlog as Future work until post reorg in early 2024, when we have more info about what our team will be and what the new org structure looks like.

@robrap
Copy link
Contributor Author

robrap commented Feb 12, 2024

Adding one more Slack thread for reference. There are many.

@jristau1984 jristau1984 moved this from Groomed to Backlog in Arch-BOM Jul 2, 2024
@jristau1984
Copy link

Closing for now, as no better owner exists in the slimmed down eng org.

@jristau1984 jristau1984 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Arch-BOM Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants